-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added forecast extension #5714
Added forecast extension #5714
Conversation
This is going to need some thought on dependencies. I cannot install this extension the same way as others due to all the stuff pulled in by darts. |
Thanks a lot for taking the time to submit this! I was able to install, I do get output though. I ran the
For the output, what I'm noticing is that the index information is lost - corresponding date values to reconstruct the time series. I am looking for a way to reconcile the differences in length between the input series and the output of
|
@jmaslek and @deeleeramone thank you for your input! I understand that the installation process for this extension is posing challenges due to the dependencies. In this direction, what is best course of action? Any input is highly appreciated. I can add more instructions to the README.md file. @deeleeramone, from the Darts documentation:
So, when we are converting the Pandas dataframe to Timeseries object, we are filling the missing dates. |
I installed the extension in a clean conda env (using dev_install.py) with the updated .toml file without hiccups. Any feedback or verification on this is highly appreciated. Thank you! [tool.poetry]
name = "openbb-forecast"
version = "0.1.0a4"
description = "Forecast Model for OpenBB"
authors = ["OpenBB Team <[email protected]>"]
readme = "README.md"
packages = [{ include = "openbb_forecast" }]
[tool.poetry.dependencies]
python = ">=3.8,<3.12"
scipy = "^1.10.1"
statsmodels = "^0.14.0"
scikit-learn = "^1.3.1"
u8darts = { extras = ["torch"], version = "^0.23.0" }
tensorboard = "^2.2.0"
openbb-core = "^1.0.0b0"
[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
[tool.poetry.plugins."openbb_core_extension"]
forecast = "openbb_forecast.forecast_router:router"
|
For Crypto assets, 24/7 is a safe assumption. But, not for other financial assets. FX trades 24/5 and stocks much less. How can we narrow the focus to market days? With a Mon-Fri schedule (mostly...), introducing weekends by copying the price values brings in unwanted, and incorrect, pieces of data. This will be especially true for intraday data, where market hours are only 6.5 hours out of the day. |
Currently, the same behavior is present in openbb_terminal forecast module. |
Yes, but that was applied as a band-aid, so it wasn't intended as a permanent solution. |
You will already have a C++ compiler installed; however, a lot of people do not and this can be a considerable pain point for many. One item to bear in mind is that the |
Ah understood! I will try to address this. |
Yeah even I faced the wrong order problem a few times. |
Just an update here. This PR is blocked by our work on the package builder that should make extensions with custom models integrate nicely. Until then this is on hold. |
Thanks for the update! I have changed base branch of this PR to develop. Edit: My git branch is messed up. So I will create a new PR once the package builder is updated. |
b0690e8
to
1a6c540
Compare
Hey @HemuManju any plans of reviving this work? Let me know and I can help out. Also @mmistroni was interested in it and suggested he can help out. P.S. It would probably be better to create the extension in a separate repo. |
@piiq, I can reopen this PR. I need to update the code based on the changes made to the OpenBB platform. |
Thanks @HemuManju 🙏, I'll have a look and create a PR into your fork with some suggestions |
Thank you @piiq 🙏 |
Hey @HemuManju Here are some thought that I have that will help to move forward:
Additional notes on things I've spotted and what we can look at after we smooth out the dependency/installation flow:
|
Hello @piiq, since this is a rewrite of the original openbb_terminal feature (credit goes to its original authors), the repo can live in openbb, and I can maintain it. |
Hey @HemuManju I've created a new repo and moved the code from this PR there. Here it is OpenBB-finance/openbb-forecast#1 I've updated some dependency settings and added instructions how to set the extension up on macOS. Would you like to connect in a call for me to onboard you? |
Hello @piiq, thank you for the update. Shall I setup a Zoom meeting? |
Description
Hello Everyone,
I hope this message finds you well. Thank you for creating and maintaining such a fantastic package. I am excited to submit this pull request for the forecast extension using SDK-v4.
In this pull request, I have included the following models for forecasting:
Regression Models:
Statistical Models:
Torch Models:
I have followed the conventions set by the technical analysis (ta) extension to ensure consistency and maintainability. This approach aligns with the existing standard data model and REST API.
How has this been tested?
Checklist:
feature/feature-name
orhotfix/hotfix-name.
Others