Checks: fix flake8 E741 remainder #3928
Conversation
github-actions
bot
added
raster
| def getmaprow_CELL(fd, buf, row, l): | ||
| def getmaprow_CELL(fd, buf, row): |
There was a problem hiding this comment.
Does this affect compatibility with the C-libraries or its Python wrappers (like ctypes)
Who can answer this?
There was a problem hiding this comment.
That's the only point that needs to be answered by someone else
scripts/db.univar/db.univar.py
Outdated
| @@ -313,23 +313,23 @@ def main(): | |||
| pval[i] = 0 | |||
|
|
|||
| inf = open(tmp + ".sort") | |||
| l = 1 | |||
| ln = 1 | |||
There was a problem hiding this comment.
Is there a better name for this one? What was the reasoning for it (does it come from a formula or something)?
I'm reading it like the natural logarithm (ln), like in maths, but doesn't make sense.
There was a problem hiding this comment.
The "line_number" is what I meant. The logarithm didn't occur to me, but you're right. Would "line_number" or "counter" make sense?
There was a problem hiding this comment.
line_number sounds better than counter for me.
There was a problem hiding this comment.
Also, a note for other readers: I don't know if this part of code is critical or not, but that loop and double loop is probably quite inefficient. Probably doing a "in" check (with a pre-created local tuple) once per loop, and in the 4+pops times it matches, then find the correct assignment.
It's not something to do with this PR.
Reminder of E741 fixes for the "locale", "python", and "scripts" directories. The majority of fixes involved renaming variable names in iterables. The "noqa: E741" was added to "scripts/d.rast.leg/d.rast.leg.py" since it didn't make sense to change just the "l".