introduce --dry-run run mode
#1881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
changed the title
--dry-run run mode
romain-intel
reviewed
Jun 5, 2024
| @@ -901,6 +899,12 @@ def version(obj): | |||
| type=click.Choice(MONITOR_SIDECARS), | |||
| help="Monitoring backend type", | |||
| ) | |||
| @click.option( | |||
There was a problem hiding this comment.
I'm not a fan of having options cause other options to be ignored with no warning. I would add a check to see if there are conflicting options. dry-run is also a bit misleading (it's not dry run and things may happen, for example conda package caching, anything the code does as well, etc).
romain-intel
reviewed
Jun 5, 2024
| ) | ||
| if all_decospecs: | ||
| decorators._attach_decorators(ctx.obj.flow, all_decospecs) | ||
| decospecs = list(decospecs or []) + list(ctx.obj.environment.decospecs() or []) |
There was a problem hiding this comment.
nit, use ctx.obj.decospecs (no point redoing the same computation and conversion)
romain-intel
reviewed
Jun 5, 2024
| # words, for the same decorator, we want `myflow.py run --with foo` to | ||
| # take precedence over any other `foo` decospec | ||
| ctx.obj.tl_decospecs = list(decospecs or []) | ||
| # run/resume can add more decorators with --with, which take precedence |
There was a problem hiding this comment.
am fine with this (and associated change) but would re-add the comment about how precedence is determined by order right now (first one wins) so we need to save to apply in before_run. (ie: this comment is correct but doesn't say why we do it this way).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the rationale for this PR is to make it easier for folks to run tests through Metaflow without reporting anything on the progress to the UI or storing any artifacts.
also includes cosmetic changes for decorator handling in cli.py which can be safely ignored (or omitted or pulled out in a separate PR)