use ast instead of loading for injecting user params #1878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
approved these changes
Jun 6, 2024
romain-intel
reviewed
Jun 6, 2024
There was a problem hiding this comment.
I think we need to find another way to do this. The main reason being that we override parameters and would at the very least have to override this function as well which feels a bit icky. I am also not 100% comfortable with the AST parsing and feel we may miss cases and spend time chasing things (could be wrong but feels less robust).
The main issue is that FlowSpec.init sets the global parameters. Maybe we can focus on that and not do that if we are loading just to evaluate the class. Thoughts?
|
|
||
| def construct_parameter(self, node): | ||
| all_values = {} | ||
| fields = ["name", "default", "type", "help", "required", "show_default"] |
There was a problem hiding this comment.
we use other parameter values so would need something a bit more generic I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.