argo-workflows runner #1868
Open
argo-workflows runner #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
reviewed
May 28, 2024
romain-intel
reviewed
Jun 6, 2024
|
|
||
| return command_obj | ||
|
|
||
| def deploy(self, **kwargs) -> "DeployedFlow": |
There was a problem hiding this comment.
why both deploy and create? Do we have both CLIs?
|
|
||
| self.cwd = cwd | ||
| self.spm = SubprocessManager() | ||
| self.top_level_kwargs = kwargs |
There was a problem hiding this comment.
There seems to be one level missing. We can have things like: myflow.py <tl options> argo/sfn/whatever <argo/sfn/whatever options> create <create options>. I only see and here I think.
| return self.deployer.trigger(**kwargs) | ||
|
|
||
|
|
||
| class Deployer(object): |
There was a problem hiding this comment.
I am debating whether we should have a common thing like this or let each CLI define everything individually. Pros and cons on both sides.
| self.deployer = deployer | ||
|
|
||
| @property | ||
| def production_token(self): |
There was a problem hiding this comment.
For example, we are getting rid of this so not sure if having it be common is a good idea.
| return getattr(api(**top_level_kwargs), _type)(name=name) | ||
|
|
||
|
|
||
| class TriggeredRun(object): |
There was a problem hiding this comment.
Functionally, is there a difference between an ExecutingRun and a TriggeredRun?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.