Fix handling of @InputArgument for Java objects with optionals. #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emily
requested changes
May 28, 2024
paulbakker
reviewed
May 28, 2024
| @@ -67,6 +69,18 @@ class DefaultInputObjectMapper(customInputObjectMapper: InputObjectMapper? = nul | |||
| if (KotlinDetector.isKotlinType(targetType.type)) { | |||
| return mapper.mapToKotlinObject(sourceMap, targetType.type.kotlin) | |||
| } | |||
|
|
|||
| if (targetType.resolvableType.hasGenerics()) { | |||
There was a problem hiding this comment.
Should this check specifically for Optional instead of any type with generics?
|
Any update? |
Sorry for the delay. I need to address some of the comments before I can push the fix through. |
|
Declining this PR in favor of a better fix here: #1951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This PR fixes handling of @InputArgument for optionals. The current implementation of the DefaultInputObjectMapper does not handling converting from map to optionals, resulting in the following error when used:
Conversion of String to Optional, for e.g works fine since Spring's
ObjectToOptionalConverterhandles this fine: https://github.com/spring-projects/spring-framework/blob/main/spring-core/src/main/java/org/springframework/core/convert/support/ObjectToOptionalConverter.javaAdding similar logic to the
DefaultInputObjectMapperto handle optionals based on this code: https://github.com/spring-projects/spring-framework/blob/main/spring-core/src/main/java/org/springframework/core/convert/support/ObjectToOptionalConverter.java#L76Describe the new behavior from this PR, and why it's needed
Issue #1925