Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TransformerEngine initialize_ub parameters #9536

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thomasdhc
Copy link
Collaborator

What does this PR do ?

Update TransformerEngine and update paramters of initialize_ub function

Collection: [nlp]

Changelog

  • Update parameter tp_size to tp_group in initialize_ub

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jun 25, 2024
@thomasdhc
Copy link
Collaborator Author

TE PR that updated the parameters: NVIDIA/TransformerEngine#901

Dong Hyuk Chang and others added 2 commits June 25, 2024 18:41
Signed-off-by: thomasdhc <[email protected]>
Signed-off-by: Dong Hyuk Chang <[email protected]>
Signed-off-by: Dong Hyuk Chang <[email protected]>
Signed-off-by: Dong Hyuk Chang <[email protected]>
@pablo-garay
Copy link
Collaborator

pablo-garay commented Jun 27, 2024

CI passed (test that failed flaky & is now fixed): https://github.com/NVIDIA/NeMo/actions/runs/9702489435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants