Proof of concept opt-in navigation modification (use KMNavigationController) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoZhouqi
force-pushed
the
master
branch
3 times, most recently
from
394ac65
to
57e0c19
Compare
MoZhouqi
force-pushed
the
master
branch
2 times, most recently
from
74d652e
to
2169f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because sometimes in complex VCs' hierarchies there happen to be bugs, and because giving a choice is generally considered a good practice (especially with such a crucial system component as navigation controller), I propose to create an opt-in version of this beautiful library.
My proposal is basically a hack (plus the last time I've been using obj-c was 4 years ago), but you can notice that there is a new
KMNavigationControllerclass, and modifications are applied only if thisUINavigationControllersubclass is being used.THE PROPOSED CODE REQUIRES HEAVY REFACTORING. Sorry for that, needed it fast.
Thank you for your consideration.
Swizzle responsibly! :P