-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataGrid: add ToODataString API to the ReadData event arguments #5582
DataGrid: add ToODataString API to the ReadData event arguments #5582
Conversation
@stsrki Any customer that would be willing to take this for a spin using 1.6 preview? |
I have someone in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Edit the page at tests/datagrid
- In OnReadData add
string oDataQuery = e.ToODataString( "https://ibm.com" );
- Run the app, visit the page
- Enter
gmail
in the email filter
Expected: oDataQuery
should have a $filter
entry
Actual: It doesn't
Fixed @mrpmorris Would you be so kind to retest? @stsrki The problem here, was that the column filter method is null on read data, which is somewhat correct since these columns have no FilterMethod specifically defined. |
Yeah, I think that should be fine. |
@mrpmorris mentioned a way to test the filter quickly.
and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@David-Moreira If you think you will not need anything else I will merge it.
Yep, fine by me. |
No description provided.