Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-33837: Workaround chown warnings #3336

Open
wants to merge 1 commit into
base: 10.5
Choose a base branch
from

Conversation

illuusio
Copy link
Contributor

@illuusio illuusio commented Jun 14, 2024

  • The Jira issue number for this PR is: MDEV-33837

Description

Blindly recursive chown is not way to do it. This Workaround is not much better than just chown -R but there is small adjustment just chown MariaDB statedir and logdir then with find only chown those files that are not correctly owned.

Fixes lintian warnings:

  • W: mariadb-server: recursive-privilege-change "chown -R" [postinst:*]
  • W: mariadb-server: recursive-privilege-change "chown -R" [postinst:*]

Release Notes

Should not change anything

How can this PR be tested?

Build deb packages with debian/autobake-debs.sh and check if /var/lib/mysql check if get suid to root as it would without this commit

Basing the PR against the correct MariaDB version

  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

Blindly recursive chown is not way to do it.
This Workaround is not much better than just chown -R but
there is small adjustment just chown MariaDB statedir and logdir
then with find only chown those files that are not correctly
owned.

Fixes lintian warnings:
 * W: mariadb-server: recursive-privilege-change "chown -R" [postinst:*]
 * W: mariadb-server: recursive-privilege-change "chown -R" [postinst:*]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant