Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Memory Leaks #7345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce Memory Leaks #7345

wants to merge 1 commit into from

Conversation

AW1534
Copy link
Contributor

@AW1534 AW1534 commented Jun 25, 2024

Before:
Screenshot from 2024-06-25 16-48-37

After:
Screenshot from 2024-06-25 16-59-08

Not much to say here.

@Rossmaxx Rossmaxx mentioned this pull request Jun 25, 2024
Closed
Rossmaxx
Rossmaxx approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@Rossmaxx
Copy link
Contributor

#6549 tried to fix the same leak but that got into merge conflicts because we removed our inbuilt memory management in favour of the STL mechanisms.

@messmerd
Copy link
Member

I think we should spend a little more time and refactor the NotePlayHandleManager class. Maybe use std::vector for storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rossmaxx Rossmaxx Rossmaxx approved these changes

@Veratil Veratil Awaiting requested review from Veratil

@sakertooth sakertooth Awaiting requested review from sakertooth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AW1534 @Rossmaxx @messmerd