Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the web app distribution doesn't contain a duplicate skiko.wasm #4958

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Make sure the web app distribution doesn't contain a duplicate skiko.wasm #4958

merged 1 commit into from
Jun 20, 2024

Conversation

eymar
Copy link
Collaborator

@eymar eymar commented Jun 12, 2024 •
edited
Loading

https://youtrack.jetbrains.com/issue/CMP-1114

Testing:

  • changed an existing test to test where added a new check for the content of the app distribution

@eymar eymar requested a review from Schahen June 12, 2024 13:12
Schahen
Schahen reviewed Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@Schahen Schahen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eymar eymar force-pushed the ok/avoid_two_skiko_wasm_in_distribution branch from 2a2a451 to 2c359f6 Compare June 20, 2024 08:43
@eymar eymar merged commit 53bf4df into master Jun 20, 2024
12 checks passed
@eymar eymar deleted the ok/avoid_two_skiko_wasm_in_distribution branch June 20, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schahen Schahen Schahen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eymar @Schahen