File associations #4957
Open
File associations #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Desktop: Add support for file associations](JetBrains#773)
[Desktop: Add support for file associations](JetBrains#773)
|
@terrakok, could you also review the new API in this PR? I am also reviewing it and the implementation. |
igordmn
reviewed
Jun 19, 2024
gradle-plugins/compose/src/test/test-projects/application/macOptions/Expected-Info.plist
Show resolved
Hide resolved
...pose/src/main/kotlin/org/jetbrains/compose/desktop/application/tasks/AbstractJPackageTask.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/jetbrains/compose/desktop/application/dsl/JvmApplicationDistributions.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/jetbrains/compose/desktop/application/dsl/JvmApplicationDistributions.kt
Outdated
Show resolved
Hide resolved
[Desktop: Add support for file associations](JetBrains#773)
terrakok
requested changes
Jun 21, 2024
...ins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/dsl/FileAssociation.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/jetbrains/compose/desktop/application/dsl/JvmApplicationDistributions.kt
Outdated
Show resolved
Hide resolved
...mpose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/InfoPlistBuilder.kt
Outdated
Show resolved
Hide resolved
...mpose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/InfoPlistBuilder.kt
Outdated
Show resolved
Hide resolved
...mpose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/InfoPlistBuilder.kt
Outdated
Show resolved
Hide resolved
...mpose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/InfoPlistBuilder.kt
Outdated
Show resolved
Hide resolved
...mpose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/InfoPlistBuilder.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/org/jetbrains/compose/desktop/application/internal/configureJvmApplication.kt
Outdated
Show resolved
Hide resolved
gradle-plugins/compose/src/test/test-projects/application/macOptions/Expected-Info.plist
Show resolved
Hide resolved
[Desktop: Add support for file associations](JetBrains#773)
[Desktop: Add support for file associations](JetBrains#773)
|
Except for DSL test and docs, everything else is fixed. Can you close the comment, @terrakok? It is not closable. What do you think about the API? It supports:
The demo project is also updated according to the new API. PS. This version is only tested on MacOS for now. I'll check the rest a bit later. |
igordmn
approved these changes
Jun 21, 2024
...src/main/kotlin/org/jetbrains/compose/desktop/application/dsl/JvmApplicationDistributions.kt
Outdated
Show resolved
Hide resolved
[Desktop: Add support for file associations](JetBrains#773)
|
I had to change resource name generation to make it stable for testing. |
|
I tested the current version on Windows, MacOS, Ubuntu, Kubuntu. On Windows, MacOS everything is ok, while on both Linux distributives there are problems (in Kubuntu there is no icon, in Ubuntu, association doesn't work), but the same thing is with idea as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add file associations support to Compose Desktop
Fixes #773
Testing
Tested on the sample project.
Behaviours per OSs:
I didn't write any unit tests because I don’t know which of them you are expecting me to write. So, I'm looking forward to your feedback and suggestions.
This should be tested by QA
Release Notes
Highlight - Desktop
nativeDistributionsblock: