Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: eliminate redundancies and remove misleading annotion #2925

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

style: eliminate redundancies and remove misleading annotion #2925

wants to merge 3 commits into from

Conversation

Trinoooo
Copy link

  1. extract the same logic in Replicas, InSyncReplicas, OfflineReplicas. Improve reusability, maintainability, and consistency
  2. remove unnecessary local variable and misleading annotion. see Sincerely ask, is this redundant? #2923

@Trinoooo
style: eliminate redundancies and remove misleading annotion
12f90a0 
1. extract the same logic in Replicas, InSyncReplicas, OfflineReplicas. Improve reusability, maintainability, and consistency
2. remove unnecessary local variable and misleading annotion. see IBM#2923

Signed-off-by: Trino <[email protected]>
@Trinoooo
style: Partitions & WriteablePartitions
723263b 
extract the same logic in Partitions and WritablePartitions

Signed-off-by: Trino <[email protected]>
@Trinoooo
style: avoid introducing unnecessary types
a1fb1e9 
remove replicasType, use extractor callback instead.

Signed-off-by: Trino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Trinoooo @dnwe