Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpu spin loop when pending is closed while buf is not empty #2922

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix cpu spin loop when pending is closed while buf is not empty #2922

wants to merge 1 commit into from

Conversation

AleksandrShibanov
Copy link

@AleksandrShibanov AleksandrShibanov commented Jun 5, 2024 •
edited
Loading

it can be situation when
on line 854 pending is ok
on line 860 we add res to buf
on line 861 pending closes in other goroutine
and then there will be cpu spin loop.

I will be glad to see your suggestions and comments

@AleksandrShibanov AleksandrShibanov mentioned this pull request Jun 5, 2024
Open
@AleksandrShibanov
Copy link
Author

#2907

puellanivis
puellanivis reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@puellanivis puellanivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this resolves the immediate symptom, I’m unsure if this is a proper solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puellanivis puellanivis puellanivis left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AleksandrShibanov @puellanivis