Add option to only dismiss the presented view controller after the pan gesture ends #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n gesture ends This preserves all the default behaviour and existing API
|
Hi there, and thank you for the pull request! So the way I see this new behaviour is that it basically makes the dismissal work like an interactive dismissal. This has been discussed extensively in #65, so I don't want to rehash it all here, but the conclusion based on that discussion was to wait to see if Apple goes all in on the interactive transition style, and if they do, reimplement this library as a proper interactive transition. Tacking on another option that would probably become redundant (or serve to carry on the "legacy" behaviour, if Apple does go fully interactive) is something I'd avoid, so I'm not going to be able to merge this. Hope you can understand. |
|
No problem at all @HarshilShah. Thanks for looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves all the default behaviour and existing API.
The proposed new behaviour matches that of the Apple Music card – user can pan below the dismiss threshold – including using multiple fingers – and the presented view will only dismiss after finishing the gesture (i.e releasing the finger).