Migrate sprites from css to a Sprite vue component #15242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negue
reviewed
Jun 14, 2024
| @@ -168,34 +174,40 @@ export default { | |||
| isAllowedToFeed () { | |||
| return isAllowedToFeed(this.item, this.userItems); | |||
| }, | |||
| getPetItemClass () { | |||
| itemClass () { | |||
| if (this.isOwned() || (this.mountOwned() && this.isHatchable()) || this.isSpecial()) { | |||
There was a problem hiding this comment.
missing the "isHatchable" alone - see https://github.com/HabitRPG/habitica/pull/15242/files#diff-4b9c11aea9816b0f238d1da7970e671a1189835e1b0bfe7aa061b48bd3401262L190 so I guess this && can be changed to a || and then it should be fine :)
phillipthelen
force-pushed
the
phillip/sprites
branch
from
44f6031
to
b200a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new Sprite component that loads images from aws similar to how we handle it in the mobile apps
Started migrating several areas
Still needs to be done (Not in this PR)