test(server) adds a test case to taskManager #15182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new test covers the case in which `getTasks` is invoked with a `dueDate` parameter. None of the existing test cases covers this case. The new test case aims to verify the behavior of `getTasks` when a `dueDate` is provided, ensuring that the `nextDue` property is properly set for daily tasks based on the given dueDate. The new test adds new coverage: - 3 lines in server/libs/tasks/utils.js, in `setNextDue` - 20 lines in server/libs/tasks/index.js, mostly in `getTasks`
drob
changed the title
|
Hey! there are currently 7 (that I count of) tests using the Shouldn't those tests also cover those lines you mentioned? or did I miss something? if so please tell me^^ |
|
Hello! I believe those are all integration tests. There aren't any tests in the unit test suite that use |
|
Ah fair point, if there are more uses of that internally it might be nice to have those tests as well :) @SabreCat LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test covers the case in which
getTasksis invoked with adueDateparameter. None of the existing test cases covers this case.The new test case aims to verify the behavior of
getTaskswhen adueDateis provided, ensuring that thenextDueproperty is properly set for daily tasks based on the given dueDate.This adds new test coverage:
setNextDuegetTasks