Add missing exception handling for IpInfo*Resolver #19750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Graylog2/graylog-plugin-enterprise#7602
IpInfo*Resolver
classes only handle a specific set of exception types. Unknown exceptions bubble up, leading to processing failure.Extend exception handling to cover all types of exceptions.
Description
When an IP address cannot be resolved against the IPInfo DB, we may receive a
com.maxmind.db.DeserializationException
fromIPinfoIPLocationDatabaseAdapter
.This may occur in 2 places:
MaxmindDataAdapter
: this class handles any exceptions in lookup.IpInfoIpAsnResolver
andIpInfoLocationResolver
: these classes only handle a subset of exception types, resulting in an unexpected exception and failure to process messages when an unknown exception is encountered.Motivation and Context
This affects all versions that support IPInfo DBs, i.e. 5.1 and up.
Types of changes
Checklist: