Add associated_assets field to Events #19740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danotorrey
requested review from
kingzacko1,
ryan-carroll-graylog,
a team and
dennisoelkers
kingzacko1
approved these changes
Jun 26, 2024
ryan-carroll-graylog
approved these changes
Jun 26, 2024
|
Thanks for the feedback/testing/reviews @ryan-carroll-graylog @kingzacko1! I will wait on merging these until tomorrow in case anyone else has feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the
associated_assets(string id array) field to Events. Also updates the event mapping accordingly. This field needs to be present at the top-level of the Event, since (similar to theMessageobject), it must be an array in order to support effective/efficient search filtering.Motivation and Context
Server changes needed for https://github.com/Graylog2/graylog-plugin-enterprise/issues/7475
Corresponding Enterprise PR: https://github.com/Graylog2/graylog-plugin-enterprise/pull/7603
How Has This Been Tested?
Verified that the new events mapping is applied successfully when the Graylog Events index is rotated. Subsequent events index successfully. See additional testing notes in corresponding PR.
/nocl