Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test for LegacyDatanodeKeystoreProvider, removed CertService de… #19735

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added test for LegacyDatanodeKeystoreProvider, removed CertService de… #19735

wants to merge 6 commits into from

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Jun 25, 2024 •
edited
Loading

Removed dependency to deprecated CertificateService, added unit tests.

/nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora requested a review from moesterheld June 25, 2024 07:25
@todvora todvora marked this pull request as ready for review June 25, 2024 07:25
moesterheld
moesterheld approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Only comment I have is that more deprecations could be set, i.e.
KeystoreMongoCollections.DATA_NODE_KEYSTORE_COLLECTION and
KeyStoreMongoCollection.dataNode(NodeId)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moesterheld moesterheld moesterheld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@todvora @moesterheld