Support defining column for related collections suggestions. #19703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
feat/support-defining-column-for-suggestions
branch
from
2934f79
to
730ea7e
Compare
dennisoelkers
force-pushed
the
feat/support-defining-column-for-suggestions
branch
from
730ea7e
to
75951da
Compare
dennisoelkers
commented
Jun 26, 2024
| @@ -79,7 +79,7 @@ const CreateFilterDropdown = ({ filterableAttributes, filterValueRenderers, onCr | |||
| buttonTitle="Create Filter" | |||
| onToggle={onToggleDropdown} | |||
| closeOnSelect={false} | |||
| dropdownZIndex={1000}> | |||
| dropdownZIndex={1050}> | |||
There was a problem hiding this comment.
This is unrelated to the purpose of this PR, but avoids the dropdown being hidden when used on e.g. drawers.
luk-kaminski
approved these changes
Jun 26, 2024
linuspahl
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is extending the properties of attributes for paginated endpoints so that a column can be specified which is used to retrieve the title for suggestions.
/nocl No user-facing change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: