Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate datanode version through node service #19691

Merged
merged 15 commits into from
Jun 28, 2024

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Jun 20, 2024

Make exact datanode version available through node service pings. The version should be then used to verify that datanodes and graylog servers run the same compatible version.

Requested in #18783
Fixes #19680

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora requested a review from moesterheld June 25, 2024 08:41
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add it to the datanode details page too

Screenshot 2024-06-25 at 10 37 53

@todvora
Copy link
Contributor Author

todvora commented Jun 25, 2024

@gally47 Thanks, good point, added:

image

Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one more minor point, otherwise everything looks good:

for completeness, I would also propagate the version already in the registerServer method of the NodePingPeriodical

@gally47 gally47 self-requested a review June 25, 2024 13:27
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend LGTM. Thanks for working on this @todvora.

@gally47 gally47 requested a review from moesterheld June 26, 2024 08:49
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you

@moesterheld moesterheld merged commit 76cd8bb into master Jun 28, 2024
6 checks passed
@moesterheld moesterheld deleted the feature/propagate-datanode-version branch June 28, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add system notification if data node version and Graylog version don't match
3 participants