-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate datanode version through node service #19691
Conversation
graylog2-server/src/main/java/org/graylog2/cluster/nodes/DataNodeDto.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gally47 Thanks, good point, added: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found one more minor point, otherwise everything looks good:
for completeness, I would also propagate the version already in the registerServer
method of the NodePingPeriodical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend LGTM. Thanks for working on this @todvora.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thank you
Make exact datanode version available through node service pings. The version should be then used to verify that datanodes and graylog servers run the same compatible version.
Requested in #18783
Fixes #19680
Types of changes
Checklist: