Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream details outputs #19685

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Stream details outputs #19685

merged 7 commits into from
Jun 27, 2024

Conversation

ousmaneo
Copy link
Contributor

@ousmaneo ousmaneo commented Jun 19, 2024 •
edited
Loading

Add the outputs section on the stream details page destination segment.

  • Allow add, edit, remove output and also assign existing

/nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo marked this pull request as ready for review June 20, 2024 12:02
@ousmaneo ousmaneo self-assigned this Jun 20, 2024
@ousmaneo ousmaneo requested review from grotlue and gally47 June 20, 2024 12:06
Base automatically changed from stream_details_indexset to cold-tier June 24, 2024 17:00
gally47
gally47 requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, found one nitpick.
I will test next.

graylog2-web-interface/src/components/streams/StreamDetails/routing-destination/OutputItem.tsx Outdated
};

const ActionButtonsWrap = styled.span`
margin-right: 6px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use theme spacings here?

gally47
gally47 requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, it works as expected.

there is one UI suggestion, the icon button actions are not consistent in color, type(outlined/filled) and also in position (row/column), I think we should consolidate them.

Screenshot 2024-06-25 at 12 18 37

Screenshot 2024-06-25 at 12 19 01

@gally47 gally47 self-requested a review June 25, 2024 13:06
gally47
gally47 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ousmaneo ousmaneo force-pushed the stream-details-outputs branch 3 times, most recently from 340d735 to b6dbf68 Compare June 25, 2024 13:43
@gally47 gally47 self-requested a review June 25, 2024 15:12
Base automatically changed from cold-tier to master June 26, 2024 09:43
@ousmaneo ousmaneo force-pushed the stream-details-outputs branch 2 times, most recently from 74b764c to 4f338ca Compare June 26, 2024 12:54
kodjo-anipah
kodjo-anipah approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@kodjo-anipah kodjo-anipah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tested adding, editing, assigning & deleting outputs

@ousmaneo ousmaneo merged commit 2ef7417 into master Jun 27, 2024
6 checks passed
@ousmaneo ousmaneo deleted the stream-details-outputs branch June 27, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodjo-anipah kodjo-anipah kodjo-anipah approved these changes

@grotlue grotlue Awaiting requested review from grotlue

@gally47 gally47 Awaiting requested review from gally47

Assignees

@ousmaneo ousmaneo

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ousmaneo @kodjo-anipah @gally47