Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup cache: bubble up error results without modifying #19670

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Lookup cache: bubble up error results without modifying #19670

wants to merge 3 commits into from

Conversation

patrickmann
Copy link
Contributor

Resolves #19159

Description

Lookup cache needs to distinguish between empty results and error results. The latter should not be altered, in particular the TTL.

How Has This Been Tested?

Unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@patrickmann patrickmann marked this pull request as ready for review June 19, 2024 06:24
@patrickmann patrickmann requested a review from a team June 19, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review error result TTL handling in lookup caches
1 participant
@patrickmann