-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency flask to v2 #884
chore(deps): update dependency flask to v2 #884
Conversation
@NimJay This too is a major version bump. So probably there are breaking changes. Should we add it to an ignore list? |
Hi @Shabirmean and @NimJay, what about give it a try with the CI? Assuming that if the app deployed in staging by CI is working successfully, that should be it, right? I see that the CI is raising an issue:
Resolving this |
Hello @mathieu-benoit That's correct Mathieu, if the CI passes then we can let it go. But like we notice it doesn't seem to like the change and we might have to take it up separately and fix the dependencies and validate before allowing renovate to do it. So it depends on how easy/important it is for the sample app to have this version updated. |
Shabir, good point about effort required (i.e., is updating flask to v2 worth the effort). I've also ticked "chore(deps): update dependency locust to v2" in #728. That is, I've asked Renovate Bot to update locust from v1 to v2. |
Renovate Ignore NotificationAs this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 2.x releases. However, if you upgrade to 2.x manually then Renovate will reenable minor and patch updates automatically. If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. |
This PR contains the following updates:
==1.1.2
->==2.1.2
Configuration
π Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
π Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.