Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate for container images in Kubernetes manifests #1310

Merged

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Nov 28, 2022

https://docs.renovatebot.com/modules/manager/kubernetes/

As soon as it's merged in main, the goal is to catch any update of any container images referenced in any Kubernetes manifests. Like for example https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/kustomize/components/google-cloud-operations/otel-collector.yaml#L71

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner November 28, 2022 22:05
@mathieu-benoit mathieu-benoit marked this pull request as draft November 28, 2022 22:05
@github-actions
Copy link

🚲 PR staged at http://35.223.27.27

1 similar comment
@github-actions
Copy link

🚲 PR staged at http://35.223.27.27

@mathieu-benoit mathieu-benoit marked this pull request as ready for review November 28, 2022 22:21
@mathieu-benoit
Copy link
Contributor Author

Ready for review, thanks!

renovate.json Outdated
@@ -39,5 +39,8 @@
},
"npm":{
"addLabels": ["lang: nodejs"]
},
"kubernetes": {
"fileMatch": ["\\.yaml$"]
Copy link
Collaborator

@NimJay NimJay Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
We should ignore release/ and kustomize/base/ since these folders are only modified when we create new release.

Copy link
Collaborator

@NimJay NimJay Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use ignorePaths.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, just updated it accordingly.

@github-actions
Copy link

🚲 PR staged at http://35.223.27.27

@mathieu-benoit mathieu-benoit self-assigned this Nov 29, 2022
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for doing this, Mathieu.

@NimJay NimJay merged commit 6a38ffd into main Nov 29, 2022
@NimJay NimJay deleted the mathieu-benoit/renovate-for-container-images-in-kubernetes branch November 29, 2022 13:31
@mathieu-benoit
Copy link
Contributor Author

FYI, like expected this update has been caught thanks to this PR: #1313

@mathieu-benoit
Copy link
Contributor Author

We could also see that the Dependency Dashboard now has Kubernetes as Detected dependencies: #728

image

D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
…tform#1310)

* Renovate for container images in Kuberentes manifests

* Update renovate.json

* ignorePaths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants