Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sleep to reduce the likelihood of eventual consistency issue #11044

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

LujieZ
Copy link
Contributor

@LujieZ LujieZ commented Jun 25, 2024

Attempt to fix hashicorp/terraform-provider-google#17332.

Release Note Template for Downstream PRs (will be copied)

resourcemanager: added a 10s wait after `google_service_account_key` creation to attempt to mitigate eventual concistency issues resulting in a `Root resource was present, but now absent` error.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 25, 2024
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after tests assuming there are no big surprises (I don't expect any)

@modular-magician modular-magician added service/iam-serviceaccount and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 1 file changed, 6 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 141
Passed tests: 111
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants