Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Config Sync enabled field in ConfigManagement Fleet-level default config #11030

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

haiyanmeng
Copy link
Contributor

@haiyanmeng haiyanmeng commented Jun 24, 2024

Add support for Config Sync enabled field in ConfigManagement Fleet-level default config. Note this field is already supported in Pantheon UI and gcloud.

The Config Sync enabled field was added in
GoogleCloudPlatform/declarative-resource-client-library@c3703a0.

Release Note Template for Downstream PRs (will be copied)

gkehub: added `config_sync.enabled` field to ConfigManagement `fleet_default_member_config`

@github-actions github-actions bot requested a review from BBBmau June 24, 2024 19:50
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 29 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 29 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 13
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • gkehub2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants