Added missing changes to "compute_security_policy" contribution docs #11024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modular-magician
added
the
awaiting-approval
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
melinath
requested changes
Jun 26, 2024
Comment on lines
353
to
354
| * `TLS_JA3_FINGERPRINT`: -- JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | ||
| * `USER_IP`: -- The IP address of the originating client, which is resolved based on "userIpRequestHeaders" configured with the securitypolicy. If there is no "userIpRequestHeaders" configuration or an IP address cannot be resolved from it, the key type defaults to IP. |
There was a problem hiding this comment.
Suggested change
| * `TLS_JA3_FINGERPRINT`: -- JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | |
| * `USER_IP`: -- The IP address of the originating client, which is resolved based on "userIpRequestHeaders" configured with the securitypolicy. If there is no "userIpRequestHeaders" configuration or an IP address cannot be resolved from it, the key type defaults to IP. | |
| * `TLS_JA3_FINGERPRINT`: JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | |
| * `USER_IP`: The IP address of the originating client, which is resolved based on "user_ip_request_headers" configured with the securitypolicy. If there is no "user_ip_request_headers" configuration or an IP address cannot be resolved from it, the key type defaults to IP. |
Comment on lines
382
to
383
| * `TLS_JA3_FINGERPRINT`: -- JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | ||
| * `USER_IP`: -- The IP address of the originating client, which is resolved based on "userIpRequestHeaders" configured with the securitypolicy. If there is no "userIpRequestHeaders" configuration or an IP address cannot be resolved from it, the key type defaults to IP. |
There was a problem hiding this comment.
Suggested change
| * `TLS_JA3_FINGERPRINT`: -- JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | |
| * `USER_IP`: -- The IP address of the originating client, which is resolved based on "userIpRequestHeaders" configured with the securitypolicy. If there is no "userIpRequestHeaders" configuration or an IP address cannot be resolved from it, the key type defaults to IP. | |
| * `TLS_JA3_FINGERPRINT`: JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | |
| * `USER_IP`: The IP address of the originating client, which is resolved based on "user_ip_request_headers" configured with the securitypolicy. If there is no "user_ip_request_headers" configuration or an IP address cannot be resolved from it, the key type defaults to IP. |
|
please also fix the changelog-checker failure |
modular-magician
removed
the
awaiting-approval
melinath
requested changes
Jun 26, 2024
mmv1/third_party/terraform/website/docs/r/compute_security_policy.html.markdown
Outdated
Show resolved
Hide resolved
…icy.html.markdown
modular-magician
added
awaiting-approval
This comment was marked as outdated.
This comment was marked as outdated.
modular-magician
removed
the
awaiting-approval
melinath
approved these changes
Jun 26, 2024
This was referenced Jun 26, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Jun 28, 2024
…oogleCloudPlatform#11024) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the documentation of the handwritten resource, adding the changes that were not documented in the following PR's:
#10761
#10596
Release Note Template for Downstream PRs (will be copied)