feat: added new field vm_tags to the workstation config

[tejal29]

Change-Id: I82b45e660fcc4ce8cc6639651cc5d06806ca2ee4

feat: added new field vm_tags to the workstation config

Release Note Template for Downstream PRs (will be copied)

 Added new field vm_tags to the workstation config

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+))
google-beta provider: Diff ( 2 files changed, 44 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 18 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_workstations_workstation_config (41 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_workstations_workstation_config" "primary" {
  host {
    gce_instance {
      vm_tags = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 66
Passed tests: 32
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workstations

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkstationsWorkstationConfig_update
• TestAccWorkstationsWorkstationConfig_updateHostDetails

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_update[Debug log]
TestAccWorkstationsWorkstationConfig_updateHostDetails[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 5 files changed, 277 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 18 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 5 files changed, 277 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 18 insertions(+))

[modular-magician]

Tests analytics

Total tests: 64
Passed tests: 29
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

• workstations

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkstationsWorkstationConfigIamBindingGenerated
• TestAccWorkstationsWorkstationConfigIamMemberGenerated
• TestAccWorkstationsWorkstationConfigIamPolicyGenerated
• TestAccWorkstationsWorkstationConfig_update
• TestAccWorkstationsWorkstationConfig_vmTags
• TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 64
Passed tests: 29
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

• workstations

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkstationsWorkstationConfigIamBindingGenerated
• TestAccWorkstationsWorkstationConfigIamMemberGenerated
• TestAccWorkstationsWorkstationConfigIamPolicyGenerated
• TestAccWorkstationsWorkstationConfig_update
• TestAccWorkstationsWorkstationConfig_vmTags
• TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_vmTags[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_vmTags[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[tejal29]

Tests failed during RECORDING mode: TestAccWorkstationsWorkstationConfigIamBindingGenerated[Error message] [Debug log] TestAccWorkstationsWorkstationConfigIamMemberGenerated[Error message] [Debug log] TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Error message] [Debug log] TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log] TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Error message] [Debug log]

Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Not sure how to fix these. We have provider: google-beta added to all the resources.

[tejal29]

Tests failed during RECORDING mode: TestAccWorkstationsWorkstationConfigIamBindingGenerated[Error message] [Debug log] TestAccWorkstationsWorkstationConfigIamMemberGenerated[Error message] [Debug log] TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Error message] [Debug log] TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log] TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Error message] [Debug log]
Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test

Not sure how to fix these. We have provider: google-beta added to all the resources.

Looks like it is coming from here.

magic-modules/mmv1/templates/terraform/examples/base_configs/iam_test_file.go.tmpl

Line 33 in 4a08ebf

func TestAcc{{ $.ResourceName }}IamBindingGenerated(t *testing.T) {

Do we need to configure some external providers for workstationconfig resource?

[tejal29]

@BBBmau Let me know if you have seen this issue on other PRs. I haven't added touched the tests which failed in this PR.

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[BBBmau]

I noticed that the new test isn't added as part of magic-modules/mmv1/third_party/terraform/services/workstations/go/resource_workstations_workstation_config_test.go.tmpl

could you add this? this may be the reason for the unusual errors. I don't see anything that stands out that would cause the rest of the tests to fail.

[tejal29]

ok. Will do.

[BBBmau]

got confirmation that the failing tests are unrelated. We can approve and merge this with the new info 🎊

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 5 files changed, 277 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 18 insertions(+))

[modular-magician]

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages

• workstations

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkstationsWorkstationConfigIamBindingGenerated
• TestAccWorkstationsWorkstationConfigIamMemberGenerated
• TestAccWorkstationsWorkstationConfigIamPolicyGenerated
• TestAccWorkstationsWorkstationConfig_update
• TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[BBBmau]

got confirmation that the failing tests are unrelated. We can approve and merge this with the new info 🎊

[tejal29]

Thanks!