-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column functionality to EditDashboard component #2097
base: master
Are you sure you want to change the base?
Add column functionality to EditDashboard component #2097
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2097 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 865 865
Lines 14169 14169
=======================================
Hits 13945 13945
Misses 224 224 ☔ View full report in Codecov by Sentry. |
#2655 Bundle Size — 10.18MiB (+0.06%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch Terdious:add-choice-number-colum... Project dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking 'console.log', global architecture and non-useful code and comments lying around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR !
I tried the feature and it works well, good job 👏
I started a more technical review, and I have a few feedbacks.
…d better column management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes, it's way better now! :)
I have a super minor feedback, but otherwise it's good for me 👏
class={cx('d-flex flex-column', style.column, stylePrimary.removePadding, { | ||
[stylePrimary.removePaddingFirstCol]: x === 0, | ||
[stylePrimary.removePaddingLastCol]: x === maxBoxes, | ||
[style.removePadding]: true // it will remove padding when in mobile view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for conditional if it's always true, you can put that in the top :
cx('d-flex flex-column', style.column, stylePrimary.removePadding, style.removePadding, ...
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Adding the deletion or addition of columns to the dashboard