Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column functionality to EditDashboard component #2097

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Jun 3, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Adding the deletion or addition of columns to the dashboard

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (e83d529) to head (786a4a9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         865      865           
  Lines       14169    14169           
=======================================
  Hits        13945    13945           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jun 3, 2024

#2655 Bundle Size — 10.18MiB (+0.06%).

786a4a9(current) vs e83d529 master#2649(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 2 regressions
                 Current
#2655
     Baseline
#2649
Regression  Initial JS 5.49MiB(+0.09%) 5.49MiB
Regression  Initial CSS 304.37KiB(+0.41%) 303.12KiB
Change  Cache Invalidation 66.09% 53.79%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2655
     Baseline
#2649
Regression  JS 7.27MiB (+0.07%) 7.27MiB
No change  IMG 2.48MiB 2.48MiB
Regression  CSS 321.16KiB (+0.39%) 319.91KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:add-choice-number-colum...Project dashboard

Copy link
Contributor Author

@Terdious Terdious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking 'console.log', global architecture and non-useful code and comments lying around

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR !

I tried the feature and it works well, good job 👏

I started a more technical review, and I have a few feedbacks.

front/package.json Outdated Show resolved Hide resolved
front/src/routes/dashboard/BoxColumns.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes, it's way better now! :)

I have a super minor feedback, but otherwise it's good for me 👏

class={cx('d-flex flex-column', style.column, stylePrimary.removePadding, {
[stylePrimary.removePaddingFirstCol]: x === 0,
[stylePrimary.removePaddingLastCol]: x === maxBoxes,
[style.removePadding]: true // it will remove padding when in mobile view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for conditional if it's always true, you can put that in the top :

cx('d-flex flex-column', style.column, stylePrimary.removePadding, style.removePadding, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants