Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PR n°7 : Add support for NACamera type - Home+Security / Indoor Camera #2032

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Mar 1, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add support for NACamera module type - Home+Security / Indoor Camera

Copy link

relativeci bot commented Mar 1, 2024

#2642 Bundle Size — 10.21MiB (+0.31%).

f572efe(current) vs 4405399 master#2630(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#2642
     Baseline
#2630
Regression  Initial JS 5.49MiB(+0.13%) 5.48MiB
No change  Initial CSS 303.12KiB 303.12KiB
Change  Cache Invalidation 54.5% 0%
No change  Chunks 51 51
Change  Assets 172(+0.58%) 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
#2642
     Baseline
#2630
Regression  JS 7.27MiB (+0.1%) 7.27MiB
Regression  IMG 2.5MiB (+0.98%) 2.48MiB
No change  CSS 319.91KiB 319.91KiB
No change  Fonts 93.55KiB 93.55KiB
Regression  Other 17.74KiB (+0.68%) 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:netatmo-security-nacame...Project dashboard

Copy link

stale bot commented May 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 2, 2024
@stale stale bot closed this May 9, 2024
@Terdious Terdious reopened this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant