[WIP] Message List Data Source Decorator #3247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
馃帹聽SDK: StreamChatUI
Generated by 馃毇 Danger |
StreamChat XCMetrics
|
|
| @@ -21,6 +21,10 @@ open class ChatMessageListVC: _ViewController, | |||
| UIGestureRecognizerDelegate, | |||
| VoiceRecordingAttachmentPresentationViewDelegate | |||
| { | |||
| open var dataSourceDecorator: (([ChatMessage]) -> [ChatMessage])? = { | |||
There was a problem hiding this comment.
shouldn't we return nil as default? This will filter system messages in the SDK.
There was a problem hiding this comment.
Yes, yes, I'm just testing this to see if Firebase Performance Metrics has any impact or not
| listView.currentMessagesFromDataSource = messages | ||
| listView.newMessagesSnapshot = messages | ||
| if let dataSourceDecorator { | ||
| let filteredMessages = dataSourceDecorator(Array(messages)) |
There was a problem hiding this comment.
the benchmark tests are failing, maybe good to run them again.
There was a problem hiding this comment.
Yes, that is the plan, thats why I'm adding a default decorator
There was a problem hiding this comment.
That line should be fine since we have background mapping enabled and if it is enabled, LazyCachedMapCollection maps all the items in the init. No performance hit here.
StreamChat XCMetrics
|
StreamChat XCMetrics
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敆 Issue Links
N/A
馃幆 Goal
Possibility of overriding the data source in the message list.
Potential edge cages:
1- If all messages from the first page are removed (unlikely), loading more messages is impossible.
2- If from the first 25 messages, only 1 or 2 are filtered, then it will feel like there are no more pages, but there is.
3- The preview message in the CHannel list might not be in sync if last message from the message list is removed
馃摑 Summary
Provide bullet points with the most important changes in the codebase.
馃洜 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
馃帹 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
馃И Manual Testing Notes
Explain how this change can be tested manually, if applicable.
鈽戯笍 Contributor Checklist
馃巵 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)