Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Random test failure with test_loadReplies_whenIsFirstPage_shouldClearCurrentMessagesExcludingLocalOnly #3246

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

laevandus
Copy link
Contributor

🎯 Goal

test_loadReplies_whenIsFirstPage_shouldClearCurrentMessagesExcludingLocalOnly sometimes fails on CI with

XCTAssertEqual failed: ("1") is not equal to ("3")
[07:04:25]: ▸ Test Case '-[StreamChatTests.MessageUpdater_Tests 

I think it is related to timing in that test where we modify data using writableContext and then expect DTOs created using the view context to update immediately.

📝 Summary

  • Read data from DB every time when asserting
  • Add convenience read methods

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@laevandus laevandus added the 🤖 CI/CD Any work related to CI/CD label Jun 12, 2024
@laevandus laevandus requested a review from a team as a code owner June 12, 2024 12:50
Copy link

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

…pdate on time for fixing sometimes failing test_loadReplies_whenIsFirstPage_shouldClearCurrentMessagesExcludingLocalOnly test
@laevandus laevandus force-pushed the fix/randomly-failing-message-updater-test branch from 8563ad6 to 7dfe25e Compare June 17, 2024 06:08
@laevandus laevandus enabled auto-merge (squash) June 17, 2024 06:08
Copy link

sonarcloud bot commented Jun 17, 2024

@martinmitrevski martinmitrevski enabled auto-merge (squash) June 17, 2024 09:17
@martinmitrevski martinmitrevski merged commit 8612e9c into develop Jun 17, 2024
14 of 15 checks passed
@martinmitrevski martinmitrevski deleted the fix/randomly-failing-message-updater-test branch June 17, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants