Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user block feature #3223

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

Implement user block feature #3223

wants to merge 39 commits into from

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented May 27, 2024

🔗 Issue Links

Resolve https://github.com/GetStream/ios-issues-tracking/issues/788

🎯 Goal

Implement user blocking feature.

🧪 Manual Testing Notes

  1. On first entry
  • Enable blocking feature in configuration
  • Open channel long-press participant's message
  • Verify action item (Block user / Unblock user)
  1. On reconnect
  • Enable blocking feature in configuration
  • Open channel
  • Block user
  • Log out and log in as the same user
  • Open channel long-press participant's message
  • Verify action item (Block user / Unblock user)
  1. Get the list of blocked users
  • Enable blocking feature in configuration
  • Open channel
  • Block user
  • Open channel debug menu
  • Open blocked users view
  • Verify that blocked user is in the list
  1. 1:1 channel
  • Enable blocking feature in configuration
  • Open a 1:1 channel
  • Block user
  • Send a message as a blocked user
  • There should be no messages from the blocked user
  1. Group channel
  • Enable blocking feature in configuration
  • Open a group channel
  • Block some user
  • Send a message as a blocked user
  • The message should be visible to the main user
  1. 1:1 channel
  • Enable blocking feature in configuration
  • Block user
  • Send a message as a blocked user to the 1:1 channel
  • Send a message as a blocked user to the group channel
  • Open the group channel and read a message
  • Go back to the channel list
  • There should be no messages from the blocked user in 1:1 channel

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

Copy link

github-actions bot commented May 27, 2024

1 Error
🚫 Please use more than one word.
795c614
2 Warnings
⚠️ Big PR
⚠️ The changes should be manually QAed before the Pull Request will be merged

Generated by 🚫 Danger

# Conflicts:
#	Sources/StreamChat/APIClient/Endpoints/EndpointPath+OfflineRequest.swift
#	Sources/StreamChat/Database/StreamChatModel.xcdatamodeld/StreamChatModel.xcdatamodel/contents
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Sources/StreamChat/Models/BlockedUser.swift Outdated Show resolved Hide resolved
Sources/StreamChat/Database/DTOs/BlockedUserDTO.swift Outdated Show resolved Hide resolved
Sources/StreamChat/StateLayer/ConnectedUser.swift Outdated Show resolved Hide resolved
Sources/StreamChat/Workers/CurrentUserUpdater.swift Outdated Show resolved Hide resolved
Sources/StreamChat/Workers/UserUpdater.swift Show resolved Hide resolved
Sources/StreamChat/Workers/UserUpdater.swift Show resolved Hide resolved
Sources/StreamChat/Workers/CurrentUserUpdater.swift Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@testableapple testableapple marked this pull request as ready for review June 13, 2024 16:27
@testableapple testableapple requested a review from a team as a code owner June 13, 2024 16:27
@testableapple testableapple added 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🪧 Demo App An Issue or PR related to the Demo App 🤞 Ready For QA A PR that is Ready for QA labels Jun 13, 2024
@laevandus laevandus self-requested a review June 14, 2024 08:58
Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons looks with lighter color and the show blocked users debug command reported JSON parsing issue

@laevandus
Copy link
Contributor

I tried QA verification steps and these worked correctly.

Copy link

sonarcloud bot commented Jun 14, 2024

@testableapple testableapple added 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK and removed 🤞 Ready For QA A PR that is Ready for QA labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪧 Demo App An Issue or PR related to the Demo App 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants