-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ThreadList and ThreadProvider (v2) #2407
Draft
arnautov-anton
wants to merge
13
commits into
master
Choose a base branch
from
feat/threads-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
force-pushed
the
feat/threads-v2
branch
from
May 29, 2024 18:47
eb1dfe5
to
386105c
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
2 times, most recently
from
June 11, 2024 11:59
d60dd9b
to
ffc1389
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
2 times, most recently
from
June 15, 2024 09:29
cb06b65
to
e5e0cd9
Compare
BREAKING CHANGE: stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information BREAKING CHANGE: theme v1 related markup and classNames have been removed BREAKING CHANGE: `themeVersion` property has been removed from `ChatContext`
…l container (#2406) BREAKING CHANGE: The VirtualizedMessageList does not provide default Footer component BREAKING CHANGE: The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel
Our build pipeline contained some quirks and the remains of previous setups. It was time to clean it up :) The main changes are: **No rollup.** Previously our build pipeline was implemented in rollup. To simplify things up, we now just run a couple of processes in parallel: tsc to build our normal distribution and type declarations, esbuild to build bundles, and a shell script to include assets in the distribution. For development, just `tsc --watch` is enough. **No babel.** Previously our rollup config included babel transpilation with babel-preset-env. That means we included babel-runtime in our distribution, and transpiled async functions into generators with the notorious `regenerator-runtime`. Babel is now excluded from the build process (but still used as a parser for JS files in eslint). Targeting ES2020 in tsc and esbuild should be enough. And we finally have regular async functions in our distribution :) **Esbuild for bundles.** We now use esbuild instead of rollup for creating a CJS bundles. And we no longer create UDM browser bundles. **TS5.** I used this opportunity to bump TypeScript version as well :) Also, removed webpack and postcss dependencies - they were not used at all. 1. Bump prettier, eslint and eslint plugin versions. Will result in *a lot* of warnings, but good for future-proofing. 2. Review our eslintrc, it's currently a bit of a mess. 3. Remove babel completely, use typescript-eslint instead. 4. Switch to `"module": "NodeNext"` in tsconfig. This is the new recommended option for libraries, but will require us to add extensions to all of our import statements, to make them fully qualified. 5. (breaking change) With `"module": "NodeNext"` we will be ready to add `"type": "module"` in our package.json. We can't do that now, because fully specified import statements are expected from module packages. 6. (breaking change) Drop all bundles. CJS bundle is kinda weird anyway. Browser bundle can be replaced by `<script type="module">`. --------- Co-authored-by: Anton Arnautov <[email protected]>
## [12.0.0-rc.1](v11.21.0...v12.0.0-rc.1) (2024-06-17) ### ⚠ BREAKING CHANGES * The VirtualizedMessageList does not provide default Footer component * The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel * stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information * theme v1 related markup and classNames have been removed * `themeVersion` property has been removed from `ChatContext` ### Bug Fixes * render typing indicator outside the VirtualizedMessageList scroll container ([#2406](#2406)) ([fcaafb6](fcaafb6)) ### Features * remove legacy style components ([#2394](#2394)) ([9410153](9410153))
arnautov-anton
force-pushed
the
feat/threads-v2
branch
from
June 21, 2024 10:05
0b4c146
to
d897374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is still work in progress...
🎯 Goal
Draft PR for the new threads API.
Adjust
stream-chat
install link on branchfeat/threads-v2
.Adjust
@stream-io/stream-chat-css
install link on branchrefactor/react-remove-legacy-style-deps
.