Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serde::Deserialize for sway-ast types #6081

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

camden-smallwood
Copy link

Description

This commit implements serde::Deserialize for all of the AST structures in the sway-ast crate. This would allow for deserializing from their serialized state, which would be useful for a number of different applications.

A few other small changes were necessary for this commit:

  • Implements serde::Deserialize for the Ident and Span types in the sway-types crate, because they are used throughout the sway-ast crate.
  • Implements Default for the ErrorEmitted trait, because it is required by serde::Deserialize.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@IGI-111 IGI-111 requested a review from a team May 31, 2024 16:43
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall but it is missing tests. You need to add some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants