feat: create and deploy a reference proxy contract for contracts with [proxy] enabled
#6069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
added
enhancement
Benchmark for 946beecClick to view benchmark
|
Benchmark for 52d495eClick to view benchmark
|
sdankel
reviewed
May 29, 2024
Benchmark for 6828faaClick to view benchmark
|
kayagokalp
force-pushed
the
kayagokalp/deploy-default-proxy
branch
from
07910ec
to
7d3613e
Compare
Benchmark for 82fee6fClick to view benchmark
|
Benchmark for 1101331Click to view benchmark
|
sdankel
reviewed
May 31, 2024
Benchmark for c157f2bClick to view benchmark
|
Benchmark for 126ba37Click to view benchmark
|
K1-R1
reviewed
Jun 3, 2024
kayagokalp
force-pushed
the
kayagokalp/deploy-default-proxy
branch
from
5ad5d69
to
a29d8a3
Compare
Benchmark for 7d4734aClick to view benchmark
|
K1-R1
previously approved these changes
Jun 5, 2024
chore: use defaults from constants chore: clippy fix feat: update proxy addres after new deployment of it refactor: remove duplicate password prompts and cleanup secret key selection chore: add remove todo comment feat: actually update proxy target if there is an address in the forc.toml clippy fix test: add proxy contract build test docs: update docs markdown lint fix comment typo docs: add proxy docs fix docs lints update docs from review Co-authored-by: K1-R1 <[email protected]> Co-authored-by: Sophie Dankel <[email protected]> pin to tag
kayagokalp
force-pushed
the
kayagokalp/deploy-default-proxy
branch
from
a29d8a3
to
9f406fd
Compare
|
I had to rebase as there were conflicts. |
Benchmark for 0a46d9bClick to view benchmark
|
Benchmark for b441f2eClick to view benchmark
|
K1-R1
approved these changes
Jun 11, 2024
Benchmark for 4fab154Click to view benchmark
|
Benchmark for 7c5e50cClick to view benchmark
|
|
I tried this out on The first deployment was successful, and the Forc.toml was updated correctly. The second time I tried deploying, I got this error: However, there are sufficient funds in the account. Blocked by FuelLabs/fuels-rs#1396 The other issue is that, for the second request, it's not clear to the user what they are signing. There should be a message like
|
Benchmark for 783259bClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #6068.
This PR adds couple of things:
[proxy]in its forc.toml. In a way that it is owned by the deployer and the target initially points to implementation contract.Buildingtext to the all forc build invocations to better inform the user about what forc is doing behind the scenes.How this works
If the user does not have a proxy table in their forc.toml, nothing changes, same old deployment procedure is followed. Only difference is that this PR improves the ux by removing the need of providing the password multiple times.
If the user has a contract with a proxy table but without an address like:
Forc automatically creates a proxy contract based on the reference implementation at SRC14. Sets its target to the implementation contract, whichever contract enabled the proxy and the owner to the deployer (signing account of the transaction).
If the user has a contract with a proxy table and an address specified like:
Forc automatically makes a set target conract call to update the proxy contract's target. Pointing it to the newly deployed impl contract which defines the proxy table.
Generated proxy contracts are stored at
~/.forc/.generated_proxy_contracts/project_namefor housekeeping.