Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify namespace import logic for parsed and typed declarations #6057

Merged
merged 10 commits into from
Jun 17, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented May 24, 2024

Description

This PR unifies the logic for namespace imports so it works for parsed and typed declarations.

Additionally it collects and handles imports from handling the use statement when collecting.

This allows the soon-to-be-introduced AST resolving pass and collection context to correctly resolve imports.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: collection Everything to do with graph collection, type collection, and the collection context. labels May 24, 2024
@tritao tritao self-assigned this May 24, 2024
@tritao tritao force-pushed the unify-namespaces-parsed-typed branch 4 times, most recently from 6850b32 to 32cac73 Compare May 31, 2024 10:12
@tritao tritao force-pushed the unify-namespaces-parsed-typed branch 5 times, most recently from d6627f1 to 0507e78 Compare June 6, 2024 13:37
@tritao tritao force-pushed the unify-namespaces-parsed-typed branch 3 times, most recently from 48bd832 to 2277be3 Compare June 13, 2024 16:34
@tritao tritao marked this pull request as ready for review June 17, 2024 12:52
@tritao tritao requested review from a team as code owners June 17, 2024 12:52
@tritao tritao force-pushed the unify-namespaces-parsed-typed branch from 9ec23d9 to 9bf6039 Compare June 17, 2024 14:15
@IGI-111 IGI-111 requested a review from a team June 17, 2024 14:55
@tritao tritao enabled auto-merge (squash) June 17, 2024 15:04
@tritao tritao merged commit 6e9130b into FuelLabs:master Jun 17, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: collection Everything to do with graph collection, type collection, and the collection context. compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants