Changed from deprecated PropTypes to prop-types package to support React 16.0.0 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FuYaoDe could we get this merged? |
|
@mckn I still get an error using this patch, related to |
|
Need this being merged... Thanks |
|
Any update? merge asap please |
updated package.json
|
I need this too. |
|
👍 - but this PR is not enough.. the |
|
@ofirdagan I've sent an email to @FuYaoDe here to try to unlock the situation. |
|
MERGE PLZ |
|
MERGE PLEASE! |
|
@jolinkomo-code @mehdijjz I haven't heard back from @FuYaoDe in my previous contact attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I changed so this package have a dependency on the "prop-types" package instead of getting the PropTypes from React. It is deprecated since a while back and PropTypes is removed in the full version for React 16.
Please accept this PR. Thanks!