Allow using piped api for comments, playlists and trending #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 379b593.
Co-Authored-By: absidue <[email protected]>
Co-authored-by: PikachuEXE <[email protected]>
Co-Authored-By: PikachuEXE <[email protected]>
Co-Authored-By: PikachuEXE <[email protected]>
This reverts commit 379b593.
Co-Authored-By: absidue <[email protected]>
Co-authored-by: PikachuEXE <[email protected]>
Co-Authored-By: PikachuEXE <[email protected]>
Co-Authored-By: PikachuEXE <[email protected]>
…reeTube into piped-support
absidue
requested changes
Apr 20, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: WIP
and removed
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
dismissed
their stale review
see #3559 (comment)
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using piped api for comments, playlists and trending
NOTE: THIS PR SHOULD BE MERGED AFTER THE V0.21 RELEASE.
Pull Request Type
Related issue
#1527
The commits for #3488 seems to have messed up on github's side (This PR was created with the same branch but has 20 less commits?)
Description
This PR will add support for using the piped api for comments, playlists and trending
Testing
Comments
Playlists
Trending
go to the trending page
it loads
click on music tab, trending page uses fallback api
make invidious the primary api with piped as fallback
set invidious api to an invalid url (ex:
meow)go to trending page, click on gaming & get an error (piped doesnt support trending tabs)
Desktop