[channel,rdpecam] framerate support and h264 bitrate tuneup #10276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oleg0421
force-pushed
the
rdpecam_client_framerate_fix
branch
from
f441fc0
to
f48c8ea
Compare
oleg0421
changed the title
|
@freerdp-bot test |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine camera frame rates and sizes, use ioctl
VIDIOC_ENUM_FRAMEINTERVALSandVIDIOC_ENUM_FRAMESIZES. Get rid of hardcoded framerate 30 andvideoSizestable.Some tuneup of how max bitrate for h264 encoding is determined: use a table based on stream resolution (height). The values are smaller comparing to old fixed value of 4 Mbps, which should help with slow uplink connections.
This fix may also help with #10274
Cc: @progxaker, @hardening, @akallabeth