[NDMII-2865] Add initial async rdnsquerier functionality. #27067
Conversation
Go Package Import DifferencesBaseline: 579d60c
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=37805298 --os-family=ubuntuNote: This applies to commit 09e92d2 |
Regression DetectorRegression Detector ResultsRun ID: b0000805-7df2-4e71-868d-7b8f30a20dfa Metrics dashboard Target profiles Baseline: 579d60c Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +3.82 | [-9.36, +17.00] | Logs |
| ➖ | basic_py_check | % cpu utilization | +1.86 | [-0.66, +4.39] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.13 | [-0.68, +0.94] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
| ➖ | idle | memory utilization | -0.44 | [-0.49, -0.39] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.57 | [-1.44, +0.30] | Logs |
| ➖ | file_tree | memory utilization | -1.29 | [-1.35, -1.22] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.41 | [-6.06, +3.24] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
jmw51798
changed the title
jmw51798
force-pushed
the
jmw/ndm-netflow-rdns-enrichment-async
branch
2 times, most recently
from
eac500c
to
4e21fde
Compare
jmw51798
added
the
qa/done
jmw51798
force-pushed
the
jmw/ndm-netflow-rdns-enrichment-async
branch
from
4e21fde
to
c73fcf5
Compare
jmw51798
force-pushed
the
jmw/ndm-netflow-rdns-enrichment-async
branch
from
c73fcf5
to
d96f7a6
Compare
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Adds initial rdnsquerier functionality as a foundation for providing reverse DNS enrichment of private IP addresses to NDM NetFlow events, and a noop rdnsquerier implementation that is used by default.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
No specific QA is needed for these changes because the component is disabled by default. QA has already been done to confirm that it is disabled by default and that the changes cause no difference in the agent or NDM NetFlow functionality. These changes can be tested/QAed with subsequent related changes once full reverse DNS enrichment and related configuration is supported.