Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] fix bundle ebpf #27048

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[CWS] fix bundle ebpf #27048

merged 1 commit into from
Jun 26, 2024

Conversation

safchain
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pr-commenter
Copy link

pr-commenter bot commented Jun 25, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37505500 --os-family=ubuntu

Note: This applies to commit f43131b

@pr-commenter
Copy link

pr-commenter bot commented Jun 25, 2024

Regression Detector

Regression Detector Results

Run ID: a86feb47-86f3-4da6-8a9b-11f28f313202 Metrics dashboard Target profiles

Baseline: a058d05
Comparison: f43131b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
tcp_syslog_to_blackhole ingress throughput +4.22 [-8.96, +17.41] Logs
pycheck_1000_100byte_tags % cpu utilization +1.14 [-3.40, +5.67] Logs
otel_to_otel_logs ingress throughput +0.96 [+0.14, +1.77] Logs
file_tree memory utilization +0.37 [+0.31, +0.42] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
basic_py_check % cpu utilization -0.44 [-3.02, +2.13] Logs
idle memory utilization -0.52 [-0.56, -0.49] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.90 [-1.78, -0.01] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@safchain safchain marked this pull request as ready for review June 26, 2024 07:51
@safchain safchain requested a review from a team as a code owner June 26, 2024 07:51
@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 26, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 26, 2024

❌ MergeQueue

PR already in the queue with status in_progress

If you need support, contact us on Slack #devflow with those details!

@dd-mergequeue dd-mergequeue bot merged commit f5f0390 into main Jun 26, 2024
328 checks passed
@dd-mergequeue dd-mergequeue bot deleted the safchain/fix-bundle-ebpf branch June 26, 2024 12:45
arch: str | Arch = CURRENT_ARCH,
):
# If we're bundling eBPF files, we need to copy the ebpf files to the right location,
# as we cannot use the go:embed directive with variables that depend on the build architecture
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't you have two different files that are architecture-specific that define the bindata variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants