Handle ".uno:DocumentStatus" instead of SlideMasterPage special-handling #9323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekaganski
force-pushed
the
private/mk/master
branch
3 times, most recently
from
ce8ccce
to
b1d9ea8
Compare
mikekaganski
changed the title
mikekaganski
force-pushed
the
private/mk/master
branch
from
b1d9ea8
to
ad96fe1
Compare
|
https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04/2490/console failed in unit-save-torture, retry. |
|
https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04_cypress_desktop/1532/console failed in impress/annotation_spec.js and impress/slide_operations_spec.js, retry. |
mikekaganski
force-pushed
the
private/mk/master
branch
from
ad96fe1
to
b41954d
Compare
The part identifier is signed; a valid response may be like type=presentation parts=1 current=0 width=15875 height=11906 viewid=4 mode=0 selectedparts=0 Slide 1 -2916 The regex must allow optional leading minus. Signed-off-by: Mike Kaganski <[email protected]> Change-Id: Ic17086415e2c1f87ec74c6c4c3d8e43d1cde02fe
Since other view modes are needed, too, not only master page view, we need to send / handle status updates not only in case of SlideMasterPage update. The ".uno:DocumentStatus" pseudo-command update sent from ChangeEditMode in core serves for that. Signed-off-by: Mike Kaganski <[email protected]> Change-Id: If7bc7ae124d161658b06784f3e86d85f3c76f3c6
It is useful to send mode always, including the default 0. The 0 is significant; and there is a JS code that treats absent mode as "current". Signed-off-by: Mike Kaganski <[email protected]> Change-Id: I8dbaaa47b302d96c8e867c1e9cb31b558e13db09
Put them near the existing Master view button. The icons are from Colibre theme. Signed-off-by: Mike Kaganski <[email protected]> Change-Id: I6468e3b2a7973ab4862563f5ae141ae46bae20d9
mikekaganski
force-pushed
the
private/mk/master
branch
from
4ab7628
to
48d79e4
Compare
eszkadev
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since other view modes are needed, too, not only master page view, we need
to send / handle status updates not only in case of SlideMasterPage update.
The new LOK_CALLBACK_STATUS_UPDATE serves for that.
Signed-off-by: Mike Kaganski [email protected]
Change-Id: If7bc7ae124d161658b06784f3e86d85f3c76f3c6