Use Workers to do tile decompression and unpremultiply #9208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Things that will help get your PR across the finish line:
|
Cwiiis
force-pushed
the
messing-with-workers
branch
3 times, most recently
from
3430ea8
to
f6b9b8e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| break; | ||
|
|
||
| default: | ||
| console.error('Unrecognised preprocessor message', e); |
Check warning
Code scanning / CodeQL
Log injection Medium
Cwiiis
force-pushed
the
messing-with-workers
branch
from
f6b9b8e
to
c6f8206
Compare
|
|
||
| console.log('MessagePreProcessor initialised', self.fzstd); | ||
|
|
||
| function onMessage(e) { |
Check warning
Code scanning / CodeQL
Missing origin verification in `postMessage` handler Medium
Cwiiis
force-pushed
the
messing-with-workers
branch
from
c6f8206
to
22547e4
Compare
Signed-off-by: Chris Lord <[email protected]> Change-Id: Idb46053e78fb44225f3f1b2a86b7ccaaf52310b2
Cwiiis
force-pushed
the
messing-with-workers
branch
from
22547e4
to
f77b5bb
Compare
Signed-off-by: Chris Lord <[email protected]> Change-Id: I67a3a400009f03c7a87fb17040c224f8e6c9ded9
Cwiiis
force-pushed
the
messing-with-workers
branch
from
f77b5bb
to
d3912ac
Compare
This removes unpremultiply from the retained allocations profile. This doesn't necessarily help with memory usage, but at least makes it easier to track. Signed-off-by: Chris Lord <[email protected]> Change-Id: I8d4a81ec6a9e771d6a37c293e3a130da0b6637d9
Cwiiis
force-pushed
the
messing-with-workers
branch
from
672568b
to
823be3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two patches; the first fixes a bug where if we receive new keyframe tiledata and need to ensure the canvas, we end up decompressing/unpremultiplying/putting the old data unnecessarily (I think). The second uses a worker to offload the majority of tile image data decompression and unpremultiplying from the main thread and improves response during large update operations (such as scrolling through a document).
The code is not properly formatted yet, I'm opening this PR now and will update it with fixes once I figure out what those fixes are...
Checklist
make checkmake runand manually verified that everything looks okay