Follow-up to PR #8170 #8273
Draft
Follow-up to PR #8170 #8273
+36
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lrineau
commented
Jun 13, 2024
Comment on lines
+165
to
+169
| #if CGAL_USE_BOOST_UNORDERED | ||
| typedef boost::unordered_flat_map<Edge, Context_list*, boost::hash<Edge>> Sc_to_c_map; | ||
| #else | ||
| typedef std::unordered_map<Edge, Context_list*, boost::hash<Edge>> Sc_to_c_map; | ||
| #endif |
There was a problem hiding this comment.
Order of the sequence of values from the range CGAL::Constrained_triangulation_plus_2<Tr>::subconstraints()
- The patch 93fd966 makes the range
CGAL::Constrained_triangulation_plus_2<Tr>::subconstraints()non-deterministic: instead of astd::mapwith a customcomparefunctor, now the sub-constraints are in an unordered map, for efficiency reasons. Note that the range was never documented as sorted or deterministic. - As my patch had broken a test from Mesh_2 (the test
test_meshing), I had to fix that non-determinism. That was complicated to fix directly inConstrained_triangulation_plus_2orConstrained_triangulation_plus_2. Instead, I have chosen to fix the only place in CGAL where the order of that range mattered, inMesh_2/include/CGAL/Mesh_2/Refine_edges.h. See the commit 82b5359.
Is that correct? That is a sort of breaking change, but the ordering of Ctp_2::constraints() was never documented.
There was a problem hiding this comment.
Jane (IRL) suggested that:
- it is documented that there is a breaking change
- and add a Tag to
Constrained_triangulation_plus_2to allow users to fallback to the previous behavior.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In the PR #8170, merged for CGAL-6.0, there was several commits that I had to revert, because they broke the testsuite results:
save_binary_file. That was no correct as regards to the C3t3 concept. It is now fixed by commit c10dcf7 from this PR.Polyline_constraint_hierarchy_2using an unordered map, instead of astd::map. The issue was that is broke the determinism of Mesh_2. See Follow-up to PR #8170 #8273 (comment).CGAL::Segment_3, for some CGAL kernels.This pull-request reintroduces those features, for CGAL-6.1.
Release Management