Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing operator options when filtering on relationships #14006

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

aptkingston
Copy link
Member

This PR fixes the issue where there were no operator options when attempting to filter on relationships in both the design section and automations. I've also removed a weird double invocation of getFields which seemed to do nothing.

Fixes https://linear.app/budibase/issue/BUDI-8389/builder-data-provider-filters-empty-operator-for-relationships

Copy link

linear bot commented Jun 24, 2024

Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Had a test run through an internal db and an external PostgreSQL db; everything looked grand 👍

@aptkingston aptkingston merged commit 26b4288 into master Jun 28, 2024
12 checks passed
@aptkingston aptkingston deleted the fix-relationship-filtering branch June 28, 2024 07:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants