Making the task_preview templates available in tag_preview widgets #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very interesting idea, I cant say I ever thought of that :) |
4 tasks
|
Closed in favor of #99 which aims to implement that alongside other things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tag_previewwidget could piggyback on @undefinedDarkness template work and just displaytask_previews itselfI'm pretty sure I only refactored the
task_previewcode for that. The current changes will break some previous behavior of thetag_previewthough. Especially the "icon preview mode" looks like crap right now, I'm not that fit with widgets. That's why it's a draft.Anyway, here is a preview of the default
task_previewtemplate being displayed in atag_preview:(Since I'm exposing the widget creating functions for that, these changes will as a sideeffect allow for arbitrarily creating as many
task_previews andtag_previews as people want to)